Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILTER functions no longer find their implementation #6954

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

FILTER functions no longer find their implementation #6954

monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels
bug Something isn't working normal SQL

Comments

@monetdb-team
Copy link

Date: 2020-08-19 19:14:34 +0200
From: @swingbit
To: SQL devs <>
Version: 11.37.11 (Jun2020-SP1)
CC: @PedroTadim

Last updated: 2020-10-19 11:06:20 +0200

Comment 27998

Date: 2020-08-19 19:14:34 +0200
From: @swingbit

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36
Build Identifier:

I struggled a few hours with a filter function of mine, which no binds to its implementation after switching from Nov2019 to Jun2020. I thought something changed in the binding details.

So I tried with the only filter function implemented with the distribution, which is the LIKE implementation, and it seems broken as well.

Query:

explain select * from (values ('one'), ('two')) as l(s), (values ('three'), ('four')) as r(s) where l.s like r.s;

Nov2019 (likejoin):

(X_29:bat[:oid], X_30:bat[:oid]) := algebra.likejoin(X_15:bat[:str], X_26:bat[:str], "":str, nil:BAT, nil:BAT, true:bit, nil:lng);

Jun2020 (crossproduct + select):
(X_31:bat[:oid], X_32:bat[:oid]) := algebra.crossproduct(X_16:bat[:str], X_30:bat[:str], false:bit);
X_34:bat[:str] := algebra.projection(X_31:bat[:oid], X_16:bat[:str]);X_35:bat[:str] := algebra.projection(X_32:bat[:oid], X_30:bat[:str]); X_38:bat[:bit] := mal.manifold("algebra":str, "like":str, X_34:bat[:str], X_35:bat[:str], "":str);

Reproducible: Always

Comment 27999

Date: 2020-08-20 11:24:38 +0200
From: @PedroTadim

Hello Roberto,

This was an issue with the cardinality of list of values expressions, which we recently fixed on default branch. I just backported it to Jun2020 on changeset 8b6db4d3910f

Comment 28000

Date: 2020-08-21 10:51:11 +0200
From: @swingbit

That was it. Also my own filter functions work now.
Thanks Pedro.

@monetdb-team monetdb-team added bug Something isn't working normal SQL labels Nov 30, 2020
@sjoerdmullender sjoerdmullender added this to the Ancient Release milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working normal SQL
Projects
None yet
Development

No branches or pull requests

2 participants