Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json parser doesn't parse integers correctly #6851

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

json parser doesn't parse integers correctly #6851

monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels
bug Something isn't working normal SQL

Comments

@monetdb-team
Copy link

Date: 2020-04-16 16:00:56 +0200
From: @aris-koning
To: SQL devs <>
Version: -- development
CC: @kutsurak

Last updated: 2020-06-03 16:58:54 +0200

Comment 27666

Date: 2020-04-16 16:00:56 +0200
From: @aris-koning

User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0
Build Identifier:

on the current default branch (f3fa4abc4ee8) there is probably a smal bug in the parsing of integers in the json module. I think the logic for handling trailing zero's is doing something wrong in the implementation of JSONintegerParser.

Reproducible: Always

Steps to Reproduce:

1.mclient -s "select cast('{"foo": 90}' as json);"
2.mclient -s "select cast('{"foo": 9}' as json);"

Actual Results:

  1. works
  2. fails

Expected Results:

should both succeed

Comment 27667

Date: 2020-04-16 16:03:00 +0200
From: @aris-koning

the actual results are reversed:

  1. fails
  2. works

excuse me

Comment 27674

Date: 2020-04-17 15:14:31 +0200
From: MonetDB Mercurial Repository <>

Changeset 40378c804b2e made by Panagiotis Koutsourakis kutsurak@monetdbsolutions.com in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=40378c804b2e

Changeset description:

Add test for Bug #6851

Comment 27675

Date: 2020-04-17 15:14:35 +0200
From: MonetDB Mercurial Repository <>

Changeset fbb484d7ec3a made by Panagiotis Koutsourakis kutsurak@monetdbsolutions.com in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=fbb484d7ec3a

Changeset description:

Fix Bug #6851
@monetdb-team monetdb-team added bug Something isn't working normal SQL labels Nov 30, 2020
@sjoerdmullender sjoerdmullender added this to the Ancient Release milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working normal SQL
Projects
None yet
Development

No branches or pull requests

2 participants