You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Date: 2010-05-05 03:23:25 +0200
From: zeuner <>
To: SQL devs <>
Version: -- development
CC: @njnes, zeuner
Last updated: 2010-08-30 09:18:31 +0200
Comment 13998
Date: 2010-05-05 03:23:25 +0200
From: zeuner <>
Created attachment 1
SQL code to show the issue
By slightly changing the test submitted with bug http://bugs.monetdb.org/show_bug.cgi?id=2361, I was able
to trigger an unrelated bug (see the attached test file
fallback-bid-collision.sql). In sql/src/storage/bat/bat_storage.mx,
function delta_bind_bat, the conditional (temp || access == RD_INS ||
!bat->bid) leads to the iBAT being returned even if the main BAT is
requested by sql.bind(...,0), when there is no main BAT in the
sql_delta structure. As long as sql.bind(...,0) and sql.bind(...,1)
are combined using algebra.kunion, this doesn't seem to create
problems. But the mergetable optimizer's logic to optimize union
computations based on overlapped MAT elements does not interact
correctly with that behaviour, which leads to the data being inserted
twice in the test file.
I have attached a patch (no-fallback-ibid.diff) which avoids this
problem by disabling the iBAT fallback, creating an empty main BAT
instead.
Attached file: fallback-bid-collision.sql (text/plain, 975 bytes)
Description: SQL code to show the issue
Comment 13999
Date: 2010-05-05 03:28:34 +0200
From: zeuner <>
Created attachment 2
possible fix
Attached file: no-fallback-ibid.diff (text/plain, 600 bytes)
Description: possible fix
fixed bug #2529
In case we did a delete all, the primary bat is gone. Before we
returned the ibat (twice). Now only when the inserts are needed and
an empty bat when the primary bat is requested.
Date: 2010-05-05 03:23:25 +0200
From: zeuner <>
To: SQL devs <>
Version: -- development
CC: @njnes, zeuner
Last updated: 2010-08-30 09:18:31 +0200
Comment 13998
Date: 2010-05-05 03:23:25 +0200
From: zeuner <>
Created attachment 1
SQL code to show the issue
By slightly changing the test submitted with bug http://bugs.monetdb.org/show_bug.cgi?id=2361, I was able
to trigger an unrelated bug (see the attached test file
fallback-bid-collision.sql). In sql/src/storage/bat/bat_storage.mx,
function delta_bind_bat, the conditional (temp || access == RD_INS ||
!bat->bid) leads to the iBAT being returned even if the main BAT is
requested by sql.bind(...,0), when there is no main BAT in the
sql_delta structure. As long as sql.bind(...,0) and sql.bind(...,1)
are combined using algebra.kunion, this doesn't seem to create
problems. But the mergetable optimizer's logic to optimize union
computations based on overlapped MAT elements does not interact
correctly with that behaviour, which leads to the data being inserted
twice in the test file.
I have attached a patch (no-fallback-ibid.diff) which avoids this
problem by disabling the iBAT fallback, creating an empty main BAT
instead.
Comment 13999
Date: 2010-05-05 03:28:34 +0200
From: zeuner <>
Created attachment 2
possible fix
Comment 14207
Date: 2010-07-02 23:25:20 +0200
From: @njnes
fixed by returning empty bat, when the primary bat is gone because of a 'delete all'
Comment 14208
Date: 2010-07-02 23:27:50 +0200
From: @njnes
Changeset d8a41f812526 made by Niels Nes niels@cwi.nl in the MonetDB repo, refers to this bug.
For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=d8a41f812526
Changeset description:
Comment 14209
Date: 2010-07-02 23:27:51 +0200
From: @njnes
Changeset e7065770051d made by Niels Nes niels@cwi.nl in the MonetDB repo, refers to this bug.
For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=e7065770051d
Changeset description:
Comment 14825
Date: 2010-08-30 09:18:31 +0200
From: @sjoerdmullender
The Jun2010-SP2 version has been released.
The text was updated successfully, but these errors were encountered: