You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mclient doesn't know anything about comments, so an SQL comment is just another SQL statement as far as mclient is concerned, and it is therefore handled exactly the same.
The Timer line is wall-clock time as measured in the client. It is the time it takes to send the SQL comment to the server and receive a reply.
As Fabian notes, the -t option in mclient works best with XQuery, since only in that case we ask the server to provide (extra) timer information.
mclient: disable timer for non-XQuery, bug #2705
The timer is incorrect for non-XQuery languages, since it was designed
and made for XQuery only. The built-in timer for SQL is more correct,
and is always available in SQL rendering mode.
Date: 2010-10-25 12:49:25 +0200
From: @mlkersten
To: clients devs <>
Version: -- development
Last updated: 2011-03-28 17:31:32 +0200
Comment 15095
Date: 2010-10-25 12:49:25 +0200
From: @mlkersten
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.5.12-1.fc12 Firefox/3.5.12
Build Identifier:
mclient -te
sql>select * from tables;
....
26 tuples (1.0s)
Timer 1111.000 msec 26 rows
sql>-- help;
Timer 0.000 msec 26 rows
Aside from the double output on performance, the Timer for comment lines ideally should not be shown, or at least with the proper number of rows.
Reproducible: Always
Steps to Reproduce:
select * from tables;
-- useless comment
2.
3.
Actual Results:
mclient -te
...
sql>select * from tables;
....
26 tuples (1.0s)
Timer 1111.000 msec 26 rows
sql>-- help;
Timer 0.000 msec 26 rows
Expected Results:
mclient -te
...
sql>select * from tables;
....
Timer 1111.000 msec 26 rows
sql>-- help;
sql>
Comment 15096
Date: 2010-10-25 12:52:17 +0200
From: @grobian
The timer option should be removed for non-XQuery languages, since it's tailored towards that scenario, and nothing more.
Comment 15098
Date: 2010-10-25 14:10:54 +0200
From: @sjoerdmullender
Mclient doesn't know anything about comments, so an SQL comment is just another SQL statement as far as mclient is concerned, and it is therefore handled exactly the same.
The Timer line is wall-clock time as measured in the client. It is the time it takes to send the SQL comment to the server and receive a reply.
As Fabian notes, the -t option in mclient works best with XQuery, since only in that case we ask the server to provide (extra) timer information.
Comment 15150
Date: 2010-10-28 14:31:27 +0200
From: @grobian
moving this bug to development, since any change here will end up there anyway.
Comment 15404
Date: 2011-01-24 13:57:07 +0100
From: @grobian
Changeset 4f1fe13efae8 made by Fabian Groffen fabian@cwi.nl in the MonetDB repo, refers to this bug.
For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=4f1fe13efae8
Changeset description:
Comment 15405
Date: 2011-01-24 13:57:56 +0100
From: @grobian
timer option removed for non-XQuery languages.
Comment 15631
Date: 2011-03-28 17:31:32 +0200
From: @sjoerdmullender
The Mar2011 version has been released.
The text was updated successfully, but these errors were encountered: